vignette: reader-facing prose cleanup (PARS)#230
Merged
Conversation
Follow-up polish on the PARS vignette from review feedback: drop internal issue numbers, remove 'tunnel' references (build infra the reader needn't know), and cut the mapping_code disagreement detail (top-diff-pattern columns + caption + the 'remaining disagreements' paragraph) since the diff is negligible. The accessible/spawning/rearing km comparison table stays, reframed as link's own routine roll-up (lnk_rollup_wsg is standalone — needs no reference) that happens to match bcfishpass. Verified with a database-free knit. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014kSEJoad4Bc553qU8eFiE6
The symbology paragraph said 'a purple segment sits below a dam' — inverted. Verified against R/lnk_pipeline_mapping_code.R (token 2 = most-relevant barrier DOWNSTREAM, emitted only when the species' blocking barriers downstream are empty) and the PARS data (every coloured reach has has_barriers_bt_dnstr = false; the 58,916 blocked reaches carry no code). Rewritten: only accessible reaches are coloured; colour names the most-significant structure downstream (necessarily non-blocking for the species) with all five classes + their colours (blue none / orange modelled / red assessed-PSCIS / purple dam / green remediated); width carries habitat use. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014kSEJoad4Bc553qU8eFiE6
Per review: the prose kept mis-stating the colour semantics (esp. red = a PSCIS crossing ranked BARRIER, not just any field-assessed crossing), and the per-map legend already carries the colour key. Cleaner to remove the whole paragraph than to keep chasing exact wording. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014kSEJoad4Bc553qU8eFiE6
NewGraphEnvironment
added a commit
that referenced
this pull request
Jul 6, 2026
#230 PARS vignette reader-facing prose cleanup (issue numbers, tunnel refs, disagreement detail removed; accessible km table reframed as standalone roll-up; mapping_code symbology paragraph dropped). Docs only. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014kSEJoad4Bc553qU8eFiE6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reader-facing prose polish on the PARS vignette, from review feedback — no artifact or numbers change.
#221/#223/#226, and drops the "before/after the fix" framing).top diff pattern/countcolumns, their explanatory caption sentence, and the "remaining disagreements concentrate on…" paragraph. The match is ~99%, so the near-zero diff isn't worth belabouring.lnk_rollup_wsg()is a standalone roll-up (link's own habitat totals, no reference required) that happens to match bcfishpass — rather than a proof-of-parity exercise.Net −12 lines. Verified with a database-free knit — the comparison table and the computed map captions render, and the flagged content is gone.
Follow-up to #226. SRED: NewGraphEnvironment/sred#24.
🤖 Generated with Claude Code
https://claude.ai/code/session_014kSEJoad4Bc553qU8eFiE6